Add simple automated (but network-requiring) test for the asynch interface#131
Open
Todd-L-Miller wants to merge 5 commits intoscitokens:masterfrom
Open
Add simple automated (but network-requiring) test for the asynch interface#131Todd-L-Miller wants to merge 5 commits intoscitokens:masterfrom
Todd-L-Miller wants to merge 5 commits intoscitokens:masterfrom
Conversation
it requires a valid scitoken for an uncached issuer.
…invokes the test with it.
…user's key cache.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -0,0 +1,124 @@ | |||
| #include <stdio.h> | |||
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include <stdio.h> | |
| #include "../src/scitokens.h" |
| @@ -0,0 +1,124 @@ | |||
| #include <stdio.h> | |||
| #include <errno.h> | |||
| #include <stdlib.h> | |||
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include <stdlib.h> | |
| #include <stdio.h> | |
| #include <stdlib.h> |
| #include <stdio.h> | ||
| #include <errno.h> | ||
| #include <stdlib.h> | ||
| #include <sys/select.h> |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include <sys/select.h> |
| #include <stdlib.h> | ||
| #include <sys/select.h> | ||
| #include <string.h> | ||
| #include <unistd.h> |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include <unistd.h> | |
| #include <sys/select.h> | |
| #include <unistd.h> |
Comment on lines
+7
to
+8
| #include <errno.h> | ||
| #include "../src/scitokens.h" |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| #include <errno.h> | |
| #include "../src/scitokens.h" |
test/asynch.cc
Outdated
Comment on lines
93
to
96
| rv = scitoken_status_get_max_fd( & status, & max_fds, & error ); | ||
| if( rv != 0 ) { | ||
| fprintf( stderr, "scitoken_status_get_max_fds() failed: %s\n", error ); | ||
| exit( -2 ); |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| rv = scitoken_status_get_max_fd( & status, & max_fds, & error ); | |
| if( rv != 0 ) { | |
| fprintf( stderr, "scitoken_status_get_max_fds() failed: %s\n", error ); | |
| exit( -2 ); | |
| rv = scitoken_status_get_max_fd(&status, &max_fds, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "scitoken_status_get_max_fds() failed: %s\n", | |
| error); | |
| exit(-2); |
test/asynch.cc
Outdated
Comment on lines
99
to
105
| struct timeval time_out{1, 0}; | ||
| int s = select( max_fds + 1, read_fds, write_fds, except_fds, & time_out ); | ||
| if( s == -1 ) { | ||
| fprintf( stderr, "select() failed: %s (%d)\n", strerror(errno), errno ); | ||
| exit( -4 ); | ||
| } else if( s == 0 ) { | ||
| fprintf( stderr, "select() timed out, checking for progress.\n" ); |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| struct timeval time_out{1, 0}; | |
| int s = select( max_fds + 1, read_fds, write_fds, except_fds, & time_out ); | |
| if( s == -1 ) { | |
| fprintf( stderr, "select() failed: %s (%d)\n", strerror(errno), errno ); | |
| exit( -4 ); | |
| } else if( s == 0 ) { | |
| fprintf( stderr, "select() timed out, checking for progress.\n" ); | |
| struct timeval time_out { | |
| 1, 0 | |
| }; | |
| int s = select(max_fds + 1, read_fds, write_fds, except_fds, &time_out); | |
| if (s == -1) { | |
| fprintf(stderr, "select() failed: %s (%d)\n", strerror(errno), | |
| errno); | |
| exit(-4); | |
| } else if (s == 0) { | |
| fprintf(stderr, "select() timed out, checking for progress.\n"); |
test/asynch.cc
Outdated
Comment on lines
108
to
112
| fprintf( stderr, "Calling scitoken_deserialize_continue()...\n" ); | ||
| rv = scitoken_deserialize_continue( & token, & status, & error ); | ||
| if( rv != 0 ) { | ||
| fprintf( stderr, "scitoken_deserialize_continue() failed: %s\n", error ); | ||
| exit( -3 ); |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| fprintf( stderr, "Calling scitoken_deserialize_continue()...\n" ); | |
| rv = scitoken_deserialize_continue( & token, & status, & error ); | |
| if( rv != 0 ) { | |
| fprintf( stderr, "scitoken_deserialize_continue() failed: %s\n", error ); | |
| exit( -3 ); | |
| fprintf(stderr, "Calling scitoken_deserialize_continue()...\n"); | |
| rv = scitoken_deserialize_continue(&token, &status, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "scitoken_deserialize_continue() failed: %s\n", | |
| error); | |
| exit(-3); |
test/asynch.cc
Outdated
Comment on lines
114
to
115
| } while( status != NULL ); | ||
|
|
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| } while( status != NULL ); | |
| } while (status != NULL); |
| print_claim(token, "iss"); | ||
| print_claim(token, "jti"); | ||
|
|
||
| scitoken_destroy( token ); |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| scitoken_destroy( token ); | |
| scitoken_destroy(token); |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines
+10
to
+11
| void | ||
| void usage(const char *self) { |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| void | |
| void usage(const char *self) { | |
| void void usage(const char *self) { |
Comment on lines
+14
to
+53
| void | ||
| void print_claim(SciToken &token, const char *claim) { | ||
| char *value; | ||
| char *error; | ||
| int rv = scitoken_get_claim_string(token, claim, &value, &error); | ||
| if (rv != 0) { | ||
| fprintf(stderr, "scitoken_get_claim_string('%s') failed: %s\n", claim, | ||
| error); | ||
| return; | ||
| } | ||
| fprintf( stdout, "%s = %s\n", claim, value ); | ||
| fprintf(stdout, "%s = %s\n", claim, value); | ||
|
|
||
|
|
||
| int main(int argc, char **argv) { | ||
| if (argc < 2) { | ||
| usage(argv[0]); | ||
| exit(-1); | ||
| } | ||
| const char *encoded = argv[1]; | ||
| int rv; | ||
| char * error; | ||
| char *error; | ||
|
|
||
|
|
||
| char cache_path[FILENAME_MAX]; | ||
| if( getcwd(cache_path, sizeof(cache_path)) == NULL ) { | ||
| if (getcwd(cache_path, sizeof(cache_path)) == NULL) { | ||
| fprintf(stderr, "Failed to determine cwd, aborting.\n"); | ||
| exit(-5); | ||
|
|
||
| const char * key = "keycache.cache_home"; | ||
| const char *key = "keycache.cache_home"; | ||
| rv = scitoken_config_set_str(key, cache_path, &error); | ||
| if (rv != 0) { | ||
| fprintf(stderr, "Failed to set %s: %s, aborting.\n", key, cache_path); | ||
| exit(-5); | ||
|
|
||
|
|
||
| SciTokenStatus status; |
Contributor
There was a problem hiding this comment.
[lint] reported by reviewdog 🐶
Suggested change
| void | |
| void print_claim(SciToken &token, const char *claim) { | |
| char *value; | |
| char *error; | |
| int rv = scitoken_get_claim_string(token, claim, &value, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "scitoken_get_claim_string('%s') failed: %s\n", claim, | |
| error); | |
| return; | |
| } | |
| fprintf( stdout, "%s = %s\n", claim, value ); | |
| fprintf(stdout, "%s = %s\n", claim, value); | |
| int main(int argc, char **argv) { | |
| if (argc < 2) { | |
| usage(argv[0]); | |
| exit(-1); | |
| } | |
| const char *encoded = argv[1]; | |
| int rv; | |
| char * error; | |
| char *error; | |
| char cache_path[FILENAME_MAX]; | |
| if( getcwd(cache_path, sizeof(cache_path)) == NULL ) { | |
| if (getcwd(cache_path, sizeof(cache_path)) == NULL) { | |
| fprintf(stderr, "Failed to determine cwd, aborting.\n"); | |
| exit(-5); | |
| const char * key = "keycache.cache_home"; | |
| const char *key = "keycache.cache_home"; | |
| rv = scitoken_config_set_str(key, cache_path, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "Failed to set %s: %s, aborting.\n", key, cache_path); | |
| exit(-5); | |
| SciTokenStatus status; | |
| void void print_claim(SciToken & token, const char *claim) { | |
| char *value; | |
| char *error; | |
| int rv = scitoken_get_claim_string(token, claim, &value, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "scitoken_get_claim_string('%s') failed: %s\n", | |
| claim, error); | |
| return; | |
| } | |
| fprintf(stdout, "%s = %s\n", claim, value); | |
| fprintf(stdout, "%s = %s\n", claim, value); | |
| int main(int argc, char **argv) { | |
| if (argc < 2) { | |
| usage(argv[0]); | |
| exit(-1); | |
| } | |
| const char *encoded = argv[1]; | |
| int rv; | |
| char *error; | |
| char *error; | |
| char cache_path[FILENAME_MAX]; | |
| if (getcwd(cache_path, sizeof(cache_path)) == NULL) { | |
| if (getcwd(cache_path, sizeof(cache_path)) == NULL) { | |
| fprintf(stderr, "Failed to determine cwd, aborting.\n"); | |
| exit(-5); | |
| const char *key = "keycache.cache_home"; | |
| const char *key = "keycache.cache_home"; | |
| rv = scitoken_config_set_str(key, cache_path, &error); | |
| if (rv != 0) { | |
| fprintf(stderr, "Failed to set %s: %s, aborting.\n", | |
| key, cache_path); | |
| exit(-5); | |
| SciTokenStatus status; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.