Add prototype version of the system JWKS cache#195
Conversation
bbockelm
force-pushed
the
system_jwks_cache
branch
from
0acec41 to
ae345dd
Compare
DrDaveD
left a comment
DrDaveD
left a comment
There was a problem hiding this comment.
The code looks good to me, although it could use some more comments and some documentation somewhere saying that it is following the WLCG system JWKS cache standard.
It makes the most sense to me to implement fetch-jwks using the same code base, as a subpackage of scitokens-cpp (without inheriting the prefix).
| return oss.str(); | ||
| } | ||
|
|
||
| bool extract_json_objects(const std::string &content, |
There was a problem hiding this comment.
I'm suprised that picojson doesn't have a function like "get me the next json object starting at this index", and "and next object starting at this index".
DrDaveD
left a comment
DrDaveD
left a comment
There was a problem hiding this comment.
This is still looking for the short names with a .0 in the cache directory, not following the released standard.
It does appear to work correctly when JWKS_CACHE_FILE is set.
3 participants
No description provided.