feat: switch minimal version to 1.25 matching default and latest usql#74
feat: switch minimal version to 1.25 matching default and latest usql#74
Conversation
also add tests with Go 1.26
Summary of ChangesHello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Go module definition to use version Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required Go version from 1.24.6 to 1.25.7 in go.mod. The change is intended to align with the requirements of the usql dependency. My review suggests a minor improvement to make the version requirement less restrictive by specifying only the major and minor version, which would also align more closely with the intent described in the pull request title.
| module github.com/sclgo/usqlgen | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The go directive is set to a specific patch version (1.25.7). It's generally better to specify only the major and minor version (1.25) to define the minimum required language version. This avoids forcing all developers and build systems to upgrade to a specific patch release, making the project easier to contribute to. This also aligns better with the PR title which mentions a minimal version of 1.25.
go 1.25
No description provided.