Skip to content

feat: switch minimal version to 1.25 matching default and latest usql#74

Merged
murfffi merged 2 commits intomainfrom
tests/go126
Feb 13, 2026
Merged

feat: switch minimal version to 1.25 matching default and latest usql#74
murfffi merged 2 commits intomainfrom
tests/go126

Conversation

@murfffi
Copy link
Member

@murfffi murfffi commented Feb 13, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Go module definition to use version 1.25.7. This change is crucial for maintaining compatibility with the latest usql tool and leveraging the improvements and features of the newer Go runtime.

Highlights

  • Go Module Version Update: The project's go.mod file has been updated to specify Go version 1.25.7, aligning with the latest stable Go release and ensuring compatibility with the default and latest usql versions.
Changelog
  • go.mod
    • Updated the required Go version from 1.24.6 to 1.25.7.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/go.yml
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required Go version from 1.24.6 to 1.25.7 in go.mod. The change is intended to align with the requirements of the usql dependency. My review suggests a minor improvement to make the version requirement less restrictive by specifying only the major and minor version, which would also align more closely with the intent described in the pull request title.

module github.com/sclgo/usqlgen

go 1.24.6
go 1.25.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The go directive is set to a specific patch version (1.25.7). It's generally better to specify only the major and minor version (1.25) to define the minimum required language version. This avoids forcing all developers and build systems to upgrade to a specific patch release, making the project easier to contribute to. This also aligns better with the PR title which mentions a minimal version of 1.25.

go 1.25

@murfffi murfffi merged commit ad2d693 into main Feb 13, 2026
5 checks passed
@murfffi murfffi deleted the tests/go126 branch February 13, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant