Skip to content

feat(syncthing): add 3rd party fallback compmletion loader#1570

Open
scop wants to merge 1 commit intomainfrom
feat/syncthing-3rdparty
Open

feat(syncthing): add 3rd party fallback compmletion loader#1570
scop wants to merge 1 commit intomainfrom
feat/syncthing-3rdparty

Conversation

@scop
Copy link
Owner

@scop scop commented Feb 5, 2026

https://syncthing.net (no online documentation for installing completions that I can find)

Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to include the URL to the top page in the commit message even if it's not a link to the documentation of the completion setup.

Or one may include the link to the corresponding line in the source code:

https://github.com/syncthing/syncthing/blob/1bba07a15210fcbdb21b98f12211cd9d8dc07ca5/cmd/syncthing/main.go#L142

By the way, I noticed a typo in the commit message: comp{m => }letion.

Otherwise, approving.

@akinomyoga
Copy link
Collaborator

The completion support seems to be based on Kongplete. Maybe we can mention this in the commit message and also in the completion file.

However, the feature to print the completion setting by install-completions seems to be provided by the unreleased Kongplete-0.3.0. The Kongplete documentation doesn't mention the usage of install-completions at all. According to WillAbides/kongplete#14, the feature to print the completion setting (so that one can eval or source the output) is only in 0.3.0 and missing in the latest official release Kongplete-0.2.0.

Footnotes

  1. this project oalders/is has only 47 stars but has a conflicting command name with microsoft/inshellisense, so I don't think we should cover oalders/is for the third-party completion loader. I've mentioned this project just for the usage of install-completions described in its documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants