-
Notifications
You must be signed in to change notification settings - Fork 412
Deprecate dpkg completion #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guillemj
wants to merge
3
commits into
scop:main
Choose a base branch
from
guillemj:pu/upstream-dpkg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # bash completion for alternatives | ||
|
|
||
| _comp_cmd_alternatives__installed() | ||
| { | ||
| local i admindir | ||
| # find the admin dir | ||
| for i in alternatives rpm/alternatives; do | ||
| [[ -d /var/lib/$i ]] && admindir=/var/lib/$i && break | ||
| done | ||
| for ((i = 1; i < cword; i++)); do | ||
| if [[ ${words[i]} == --admindir ]]; then | ||
| admindir=${words[i + 1]} | ||
| break | ||
| fi | ||
| done | ||
| [[ -d $admindir ]] && _comp_compgen_split -- "$(command ls "$admindir")" | ||
| } | ||
|
|
||
| _comp_cmd_alternatives() | ||
| { | ||
| local cur prev words cword comp_args | ||
| _comp_initialize -- "$@" || return | ||
|
|
||
| case $prev in | ||
| --altdir | --admindir) | ||
| _comp_compgen_filedir -d | ||
| return | ||
| ;; | ||
| --help | --usage | --version) | ||
| return | ||
| ;; | ||
| esac | ||
|
|
||
| local mode="" args i | ||
|
|
||
| # find which mode to use and how many real args used so far | ||
| for ((i = 1; i < cword; i++)); do | ||
| if [[ ${words[i]} == --@(install|remove|auto|display|config|remove-all|set) ]]; then | ||
| mode=${words[i]} | ||
| args=$((cword - i)) | ||
| break | ||
| fi | ||
| done | ||
|
|
||
| case ${mode-} in | ||
| --install) | ||
| case $args in | ||
| 1 | 3) | ||
| _comp_compgen_filedir | ||
| ;; | ||
| 2) | ||
| _comp_cmd_alternatives__installed | ||
| ;; | ||
| 4) | ||
| # priority - no completions | ||
| ;; | ||
| *) | ||
| case $((args % 4)) in | ||
| 0 | 2) | ||
| _comp_compgen_filedir | ||
| ;; | ||
| 1) | ||
| _comp_compgen -- -W '--slave' | ||
| ;; | ||
| 3) | ||
| _comp_cmd_alternatives__installed | ||
| ;; | ||
| esac | ||
| ;; | ||
| esac | ||
| ;; | ||
| --remove | --set) | ||
| case $args in | ||
| 1) | ||
| _comp_cmd_alternatives__installed | ||
| ;; | ||
| 2) | ||
| _comp_compgen_filedir | ||
| ;; | ||
| esac | ||
| ;; | ||
| --auto | --remove-all | --display | --config) | ||
| _comp_cmd_alternatives__installed | ||
| ;; | ||
| *) | ||
| _comp_compgen_help - <<<"$(LANG=C "$1" --help 2>&1 | command sed ' | ||
| /usage:/,/^[[:space:]]*$/{ | ||
| s/^\([[:space:]]*usage:\)\{0,1\}[[:space:]]*[^[:space:]]*alternatives / / | ||
| s/^[[:space:]]*\[\(-.*\)\]/ \1/ | ||
| } | ||
| /common options:/,$s/ --/\n --/g')" | ||
| ;; | ||
| esac | ||
| } && | ||
| complete -F _comp_cmd_alternatives alternatives |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # dpkg-reconfigure(1) completion | ||
|
|
||
| _comp_cmd_dpkg_reconfigure() | ||
| { | ||
| local cur prev words cword comp_args | ||
| _comp_initialize -- "$@" || return | ||
|
|
||
| local opt | ||
|
|
||
| local noargopts='!(-*|*[fp]*)' | ||
| # shellcheck disable=SC2254 | ||
| case $prev in | ||
| --frontend | -${noargopts}f) | ||
| if _comp_expand_glob opt '/usr/share/perl5/Debconf/FrontEnd/*'; then | ||
| opt=("${opt[@]##*/}") | ||
| opt=("${opt[@]%.pm}") | ||
| _comp_compgen -- -W '"${opt[@]}"' | ||
| fi | ||
| return | ||
| ;; | ||
| --priority | -${noargopts}p) | ||
| _comp_compgen -- -W 'low medium high critical' | ||
| return | ||
| ;; | ||
| esac | ||
|
|
||
| if [[ $cur == -* ]]; then | ||
| _comp_compgen -- -W '--frontend --priority --all --unseen-only --help | ||
| --showold --force --terse' | ||
| else | ||
| _comp_compgen -x dpkg installed_packages | ||
| fi | ||
| } && | ||
| complete -F _comp_cmd_dpkg_reconfigure -o default dpkg-reconfigure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
completions-core/dpkg-source.bash → completions-fallback/dpkg-source.bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
completions-core/dselect.bash → completions-fallback/dselect.bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be named dpkg-reconfigure.bash -- it does not seem to do anything particularly useful when sourced on demand on
debconf <TAB>, and on the other hand as it stands, it won't be sourced fordpkg-reconfigure <TAB>. Let's correct the top level comment while at it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to split it up, this was just carried over from what I had locally, and perhaps that was more of a draft at the time, and when I prepared it for submission it just all seemed to be tied together.
For the debconf name, I think I went with project name as grouping, but I see that does not make sense as you point out it would not trigger any auto-loading. Will rename.