wire session factory and partial flyweight optional support#94
Open
kapilt wants to merge 1 commit intoscopely-devops:developfrom
Open
wire session factory and partial flyweight optional support#94kapilt wants to merge 1 commit intoscopely-devops:developfrom
kapilt wants to merge 1 commit intoscopely-devops:developfrom
Conversation
Contributor
Author
|
wrt to query model, https://github.com/capitalone/cloud-custodian/blob/master/c7n/query.py#L81 that's basically just a base layer reimplementing the query logic embedded in resource.py but also just working with the raw data structs |
Contributor
Contributor
|
I like this basic approach. I'm going to play around with it a bit this weekend and may have more comments. |
Contributor
Author
|
fwiw, i've been expanding out use of skew models to include aws config support. also considering expansion to include create, modify, delete events. |
|
Any chance this can be amended and merged? Would be really nice to be able to use this.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure wrt to approach here, i've tried a separate query executor class against extant meta models as well, which might be a little nicer, but wanted to try and see what it looked like to modify extant for library usage.
This unifies the client creation behind a passed object (session_factory) through most of the tree. cloudwatch usage is made lazy, as client construction does require reading model files and is noticable in lambda. there's partial support for choosing between flyweight resource classes and raw dictionaries.
mostly to start a discussion, i'll post a query branch later this week for comparison.