Skip to content

jquery 3.0 compatible#242

Open
klucznik wants to merge 2 commits into
scottcheng:masterfrom
klucznik:master
Open

jquery 3.0 compatible#242
klucznik wants to merge 2 commits into
scottcheng:masterfrom
klucznik:master

Conversation

@klucznik

Copy link
Copy Markdown

No description provided.

Comment thread .gitignore
.DS_Store
node_modules
bower_components
yarn.lock No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use unix line ending (add a newline)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Mlunoe: now cropit works with jquery 3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klucznik did all the hard work though

@mlunoe

mlunoe commented Oct 6, 2017

Copy link
Copy Markdown

@scottcheng is there a reason why this is not being merged, other than my minor comment?

@francois-ferrandis

Copy link
Copy Markdown

I would love to see this PR merged and released. 👍

Comment thread .gitignore
.DS_Store
node_modules
bower_components
yarn.lock No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yarn.lock
yarn.lock

@mlunoe

mlunoe commented Oct 11, 2020

Copy link
Copy Markdown

@scottcheng would it be possible to get this merged soon?

@TheDoctor0

Copy link
Copy Markdown

@scottcheng, would be great if you could merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants