Skip to content

ci: add installer-test caller workflow#20

Open
scottconverse wants to merge 1 commit into
masterfrom
ci/add-installer-test
Open

ci: add installer-test caller workflow#20
scottconverse wants to merge 1 commit into
masterfrom
ci/add-installer-test

Conversation

@scottconverse

Copy link
Copy Markdown
Owner

Adds the reusable installer-test caller from scottconverse/installer-ci. On merge (and on this PR) it auto-detects this repo's installer type(s) and runs a full build/install/launch/upgrade/uninstall test. No-ops green if no installer is detected.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c612ed61b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

workflow_dispatch:
jobs:
installer-test:
uses: scottconverse/installer-ci/.github/workflows/installer-test.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Configure installer-ci instead of relying on auto-detect

This calls installer-ci with no inputs, so its default detector will scan the whole monorepo. I checked the referenced workflow: it adds python-pip-wheel for any pyproject.toml, go-binary for any go.mod, and docker-image for any Dockerfile, then its Python step runs python -m build at the checkout root and its Go step defaults to go build ... .. This repo has services/*/pyproject.toml, tray/go.mod, and several subdir Dockerfiles but no root Python package or root Go module (go list . fails), so every PR/push to master will fan out into failing non-installer jobs before testing the actual Windows/macOS/Linux installer scripts. Add repo-specific inputs/support in installer-ci or keep this disabled until the detector can target the real installer build paths.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant