Fix reload guard perma-fail#31
Open
rossjrw wants to merge 1 commit into
Open
Conversation
On network connectivity loss, the resize iframe will fail to load; its src will still be set (which prevents it from being set to the same value in future, to block unnecessary reloads), but if it failed, that src does not actually represent the resized heigt. Subsequent attempts to correct the height to that value, even with connectivity restored, will fail because the src already looks right. We can avoid that by checking if the iframe load succeeded. This only helps for consecutive requests to set the value to a given height; a further request to set the value to a new height would have succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On network connectivity loss, the resize iframe will fail to load; its src will still be set (which prevents it from being set to the same value in future, to block unnecessary reloads), but if it failed, that src does not actually represent the resized height. Subsequent attempts to correct the height to that value, even with connectivity restored, will fail because the src already looks right. We can avoid that by checking if the iframe load succeeded.
This only helps for consecutive requests to set the value to a given height; a further request to set the value to a new height would have succeeded.