Skip to content

[Bug Fix]Add missing denoise parameter export for advanced sampler node#41

Open
chaserhkj wants to merge 1 commit into
scraed:masterfrom
chaserhkj:adv_node_fix
Open

[Bug Fix]Add missing denoise parameter export for advanced sampler node#41
chaserhkj wants to merge 1 commit into
scraed:masterfrom
chaserhkj:adv_node_fix

Conversation

@chaserhkj
Copy link
Copy Markdown

The advanced sampler node function does take denoising strength parameter, however it is not exported through the ComfyUI custom node class interface, thus it is missing from the UI.

This PR fixes that.

The change has been tested locally.

@scraed
Copy link
Copy Markdown
Owner

scraed commented Sep 5, 2025

Hi thanks for the fix! But I checked the latest parameters of Comfy's advanced sampler node, there seems no denoising strength parameter. Are you sure it belongs to the advanced sampler?

class KSamplerAdvanced:
    @classmethod
    def INPUT_TYPES(s):
        return {"required":
                    {"model": ("MODEL",),
                    "add_noise": (["enable", "disable"], ),
                    "noise_seed": ("INT", {"default": 0, "min": 0, "max": 0xffffffffffffffff, "control_after_generate": True}),
                    "steps": ("INT", {"default": 20, "min": 1, "max": 10000}),
                    "cfg": ("FLOAT", {"default": 8.0, "min": 0.0, "max": 100.0, "step":0.1, "round": 0.01}),
                    "sampler_name": (comfy.samplers.KSampler.SAMPLERS, ),
                    "scheduler": (comfy.samplers.KSampler.SCHEDULERS, ),
                    "positive": ("CONDITIONING", ),
                    "negative": ("CONDITIONING", ),
                    "latent_image": ("LATENT", ),
                    "start_at_step": ("INT", {"default": 0, "min": 0, "max": 10000}),
                    "end_at_step": ("INT", {"default": 10000, "min": 0, "max": 10000}),
                    "return_with_leftover_noise": (["disable", "enable"], ),
                     }
                }

@chaserhkj
Copy link
Copy Markdown
Author

Nice catch, I think this could be considered a bug to ComfyUI as well ,since you can see here the sample function defines the denoise parameter with default value being 1, but it is just not changed anywhere. I don't really think this makes any sense, I would imagine anyone who pulls out the advanced sampler wants as many controls as possible, instead of just having a random parameter masked to always be the default value...

I would sent the PR to them too when I had time back on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants