[Bug Fix]Add missing denoise parameter export for advanced sampler node#41
Open
chaserhkj wants to merge 1 commit into
Open
[Bug Fix]Add missing denoise parameter export for advanced sampler node#41chaserhkj wants to merge 1 commit into
chaserhkj wants to merge 1 commit into
Conversation
Owner
|
Hi thanks for the fix! But I checked the latest parameters of Comfy's advanced sampler node, there seems no denoising strength parameter. Are you sure it belongs to the advanced sampler? class KSamplerAdvanced:
@classmethod
def INPUT_TYPES(s):
return {"required":
{"model": ("MODEL",),
"add_noise": (["enable", "disable"], ),
"noise_seed": ("INT", {"default": 0, "min": 0, "max": 0xffffffffffffffff, "control_after_generate": True}),
"steps": ("INT", {"default": 20, "min": 1, "max": 10000}),
"cfg": ("FLOAT", {"default": 8.0, "min": 0.0, "max": 100.0, "step":0.1, "round": 0.01}),
"sampler_name": (comfy.samplers.KSampler.SAMPLERS, ),
"scheduler": (comfy.samplers.KSampler.SCHEDULERS, ),
"positive": ("CONDITIONING", ),
"negative": ("CONDITIONING", ),
"latent_image": ("LATENT", ),
"start_at_step": ("INT", {"default": 0, "min": 0, "max": 10000}),
"end_at_step": ("INT", {"default": 10000, "min": 0, "max": 10000}),
"return_with_leftover_noise": (["disable", "enable"], ),
}
} |
Author
|
Nice catch, I think this could be considered a bug to ComfyUI as well ,since you can see here the sample function defines the denoise parameter with default value being 1, but it is just not changed anywhere. I don't really think this makes any sense, I would imagine anyone who pulls out the advanced sampler wants as many controls as possible, instead of just having a random parameter masked to always be the default value... I would sent the PR to them too when I had time back on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advanced sampler node function does take denoising strength parameter, however it is not exported through the ComfyUI custom node class interface, thus it is missing from the UI.
This PR fixes that.
The change has been tested locally.