feat(ebay): expose pagination.has_more; is_sponsored is now nullable#18
Merged
Conversation
has_more is the stop signal for bulk extraction of completed/sold listings. Without it the field was dropped by the model (extra=ignore), so SDK users could not page to the end: total_pages/total_results are null on that grid, and past the last page eBay re-serves it rather than returning empty. is_sponsored becomes bool | None, defaulting to None. eBay renders its Sponsored badge into every card as anti-scraping bait, so the API now reports null instead of true-for-everything.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks scrape-badger/scrapebadger#609.
Pagination.has_more— the stop signal for bulk extraction of completed/sold listings. The model usesextra="ignore", so without this field the SDK silently dropped it and users could not page to the end:total_pages/total_resultsarenullon the sold grid, and past the last page eBay re-serves that page instead of returning empty.SearchResult.is_sponsored— nowbool | None, defaulting toNone. eBay renders its "Sponsored" badge into every card as anti-scraping bait, so the API reportsnullrather thantruefor 100% of results.Both are additive/widening: existing code reading
is_sponsoredstill type-checks againstbool | Noneconsumers, and no field was removed.