adding benchmarking, currently only for http funcs#247
Draft
albertedwardson wants to merge 3 commits intoscrapy:masterfrom
Draft
adding benchmarking, currently only for http funcs#247albertedwardson wants to merge 3 commits intoscrapy:masterfrom
albertedwardson wants to merge 3 commits intoscrapy:masterfrom
Conversation
albertedwardson
added a commit
to albertedwardson/w3lib
that referenced
this pull request
Jul 27, 2025
b5fa1b2 to
6e44d36
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 9 9
Lines 491 491
Branches 83 83
=======================================
Hits 481 481
Misses 6 6
Partials 4 4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running
on
microoptsbranchon
microoptsbranch commit 789e5deon
mainheaders_dict_to_rawperformance regressed inmany_repeated_headers(e.g. cookies) caseI believe it`s cause of using bytes leads to frequent object recreation and copying, which is more expensive than growing a bytearray, especially when building larger payloads.
but
headers_raw_to_dictshows improvements across all cases.given that real-world headers are rarely tiny, I plan to stick with bytearray for now, as it provides more consistent performance under realistic conditions.