Skip to content
This repository was archived by the owner on May 3, 2018. It is now read-only.

Fix line-height issue#15

Open
Chriscbr wants to merge 1 commit intoscratchfoundation:masterfrom
Chriscbr:patch-1
Open

Fix line-height issue#15
Chriscbr wants to merge 1 commit intoscratchfoundation:masterfrom
Chriscbr:patch-1

Conversation

@Chriscbr
Copy link
Copy Markdown

It's been bothering me for a long time. :P 1.5em seems to be the unit used on the normal mediawiki skin we had before, and I think it improves readability.

It's been bothering me for a long time. :P 1.5em seems to be the unit used on the normal mediawiki skin we had before, and I think it improves readability.
@nathan
Copy link
Copy Markdown
Collaborator

nathan commented Jul 14, 2013

It's generally better to use 1.5 rather than 1.5em. See http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/ for more information.

@Chriscbr
Copy link
Copy Markdown
Author

By the way, I'm kinda new to github.

@seotts
Copy link
Copy Markdown
Contributor

seotts commented Jul 17, 2013

Hmm... it looks like it's messing up the spacing with the pencil icon for me. See that? http://screencloud.net/v/pevz

@Chriscbr
Copy link
Copy Markdown
Author

Oh... that's odd. Hmm.

@maxamillion40
Copy link
Copy Markdown
Contributor

So do we need to pull this in?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants