-
Notifications
You must be signed in to change notification settings - Fork 100
Refactor/keyboard UI manager #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/keyboard UI manager #542
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for the issue and the PR, @bhanu-dev82! We'll try to finalize the review in the coming days :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @bhanu-dev82
Thanks for adding the tests along with it.
|
Would one of you be able to fix the failing tests, @bhanu-dev82 or @angrezichatterbox? :) |
|
I would be able to look into it later today evening. |
56a7896 to
eb139b6
Compare
|
@andrewtavis It is ready for review :) |
|
praise: Hey @bhanu-dev82 and @angrezichatterbox! All's generally working well, and this is really improving the structure of the code! |
I would look into it now |
|
Looks like we'll need to run |
|
Just ran |
d840ca4 to
3fe946a
Compare
|
I am not sure if what I did is right. Could you have a look @andrewtavis for the submodule |
1245f7a to
847e2e4
Compare
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: All's working perfectly now, @bhanu-dev82 and @angrezichatterbox! Thank you both for this whole process! A very important issue, a great execution and also finishing touches to bring all of this in 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request refactors
GeneralKeyboardIMEto improve separation of concerns by extracting UI-related logic into a dedicatedKeyboardUIManager.Summary of changes
GeneralKeyboardIME.ktinto a newKeyboardUIManager.ktGeneralKeyboardIMEso it focuses primarily onInputMethodServicelifecycle and coordinationGeneralKeyboardIMETest.ktto reflect the new architectureKeyboardUIManagerTest.ktto validate UI state handling independentlyRelated issue
Closes #540