Conversation
5 tasks
greged93
reviewed
Nov 3, 2025
Contributor
greged93
left a comment
greged93
left a comment
There was a problem hiding this comment.
looks good, just a comment related to keeping the ratio as an input.
Thegaram
commented
Nov 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the GALILEO hard fork by introducing a new fee calculation mechanism based on compressed transaction size. The key change is moving from a compression ratio-based penalty system (FEYNMAN) to a direct compressed size-based formula.
- Added
compressed_sizefield toScrollTransactionandScrollTxTrtrait - Implemented
calculate_tx_l1_cost_galileofunction with new fee formula - Updated
calculate_tx_l1_costto handle GALILEO spec ID - Added unit tests for the new GALILEO fee calculation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/transaction.rs | Added compressed_size field and getter to support GALILEO fee calculations |
| src/l1block.rs | Implemented GALILEO fee calculation logic and added unit tests |
| src/handler.rs | Updated fee calculation calls to pass the new compressed_size parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
georgehao
reviewed
Nov 5, 2025
georgehao
reviewed
Nov 5, 2025
jonastheis
previously approved these changes
Nov 5, 2025
mmjahanara
previously approved these changes
Nov 5, 2025
Thegaram
dismissed stale reviews from greged93, mmjahanara, and jonastheis
via
261ada5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://www.notion.so/scrollzkp/Galileo-Fee-Model-2a07792d22af8051a9e5e987c23c2c6a
L2geth: scroll-tech/go-ethereum#1251