Skip to content

fix: unwriteable was still can_write in all but name#2418

Merged
ilan-gold merged 4 commits into
mainfrom
ig/fix_unwriteable
May 7, 2026
Merged

fix: unwriteable was still can_write in all but name#2418
ilan-gold merged 4 commits into
mainfrom
ig/fix_unwriteable

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

When I made the change, I just ctrl + F'ed this, but forgot that we inverted the semantics from can_write. We also were never checking the index, which I discovered in #2379

  • Closes #
  • Tests added
  • Release note not necessary because: Unreleased feature fix

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.50%. Comparing base (70fcdce) to head (468b2a0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
- Coverage   87.44%   85.50%   -1.95%     
==========================================
  Files          49       49              
  Lines        7736     7739       +3     
==========================================
- Hits         6765     6617     -148     
- Misses        971     1122     +151     
Files with missing lines Coverage Δ
src/anndata/_core/anndata.py 86.49% <100.00%> (+0.05%) ⬆️

... and 8 files with indirect coverage changes

@ilan-gold ilan-gold changed the title fix: unwriteable was still can_write fix: unwriteable was still can_write in all but name May 5, 2026
@ilan-gold ilan-gold added this to the 0.13.0 milestone May 6, 2026
@ilan-gold ilan-gold requested a review from flying-sheep May 6, 2026 09:24
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Sorry for not catching the missing logic inversion in the original PR.

@ilan-gold ilan-gold merged commit 3dd761b into main May 7, 2026
25 of 26 checks passed
@ilan-gold ilan-gold deleted the ig/fix_unwriteable branch May 7, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants