Select channels#395
Open
LucaMarconato wants to merge 32 commits into
Open
Conversation
Given that the code is private and we know which function is used for which widget I removed the overhead that the wrapper creates
- Remove the dedicated Channels widget from SdataWidget; channel-specific layer loading is now triggered from the View panel instead. - Add an 'add in new layer' checkbox inline with the Vars label. When checked, double-clicking a var (or a multi-selection of vars) loads each selected channel as a new napari layer instead of navigating the slider. - Multi-selection support: mousePressEvent captures the pre-click selection so that double-clicking any already-selected item acts on the full set. AListWidget emits load_channels(tuple) once for all selected channels. - Sequential queue in SdataWidget (_enqueue_channel / _process_queue): channels are loaded one after the other without blocking the UI or showing 'Please wait'. _onClick retains its original guard for user-initiated single-element loads. - Fix: skip dims.set_point and _channel_changed processing when the active layer is a 2D channel-specific image (no channel dimension to navigate). - Add test_add_in_new_layer_multiple_channels covering async sequential loading of three channels via _enqueue_channel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #365
See PR description from @melonora there.