Fix deprecation GUI warnings for private napari attribute access#396
Merged
Conversation
Replace `Window._dock_widgets` with the public `dock_widgets` property (removing now-redundant `.widget()` calls since the public API returns the inner widget directly). Remove dead-code assignments to `DataModel._region_key` and `DataModel._instance_key`, whose backing fields are never read — the public properties derive both values from `get_table_keys(self.adata)` — and drop the unused dataclass fields. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Window._dock_widgetswith the publicdock_widgetsproperty (removing now-redundant.widget()calls since the public API returns the inner widget directly). Remove dead-code assignments toDataModel._region_keyandDataModel._instance_key, whose backing fields are never read — the public properties derive both values fromget_table_keys(self.adata)— and drop the unused dataclass fields.