obs. vs. obs for all grouped plots using BasePlot#2769
Open
yugeji wants to merge 28 commits into
Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 75.24% 75.12% -0.13%
==========================================
Files 116 116
Lines 12802 12847 +45
==========================================
+ Hits 9633 9651 +18
- Misses 3169 3196 +27
|
ivirshup
self-requested a review
January 11, 2024 15:35
flying-sheep
requested review from
flying-sheep
and removed request for
ivirshup
February 22, 2024 15:37
Comment on lines
+478
to
+483
| # _matrix.columns = [f"{x}_{idx}" for idx, x in enumerate(_matrix.columns)] # added warning as this row was commented out | ||
| if _matrix.columns.value_counts().max() > 1: | ||
| warn( | ||
| "Duplicate gene or condition labels present." | ||
| "Results might be unexpected." | ||
| ) |
Member
There was a problem hiding this comment.
@yugeji commenting this out doesn’t work with newer pandas versions anymore. Does your branch handle duplicated columns? Then we can just move this into the if len(self.groupby_cols) < 1: branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupby_colsparams