Skip to content

refactor: parse localnodes responses with streaming parser#148

Merged
dkropachev merged 1 commit into
mainfrom
dk/localnodes-streaming-parser
Jul 21, 2026
Merged

refactor: parse localnodes responses with streaming parser#148
dkropachev merged 1 commit into
mainfrom
dk/localnodes-streaming-parser

Conversation

@dkropachev

@dkropachev dkropachev commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move /localnodes response parsing out of AlternatorLiveNodes into LocalNodesResponseParser
  • replace comma splitting with a streaming JSON string-array parser
  • handle empty arrays, malformed bodies, escaped host strings, invalid host entries, and valid multi-host responses
  • keep malformed successful /localnodes responses non-fatal on main

Closes #142

Testing

  • JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 PATH=/usr/lib/jvm/java-11-openjdk-amd64/bin:$PATH mvn -q -Dtest=LocalNodesResponseParserTest,AlternatorLiveNodesClusterDiscoveryTest,ConnectionLeakTest test
  • JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 PATH=/usr/lib/jvm/java-11-openjdk-amd64/bin:$PATH mvn -q fmt:check checkstyle:check

@dkropachev
dkropachev force-pushed the dk/localnodes-streaming-parser branch from faaf31f to 64aa496 Compare July 21, 2026 16:09
@dkropachev
dkropachev merged commit e4901a6 into main Jul 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move /localnodes JSON parsing out of AlternatorLiveNodes

1 participant