Skip to content

Close polling client during live node shutdown #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkropachev merged 1 commit into from
Jul 21, 2026
Merged

Close polling client during live node shutdown #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/scylladb/alternator/internal/AlternatorLiveNodes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public class AlternatorLiveNodes extends Thread {
private final AtomicBoolean shutdownRequested = new AtomicBoolean(false);
private final SdkHttpClient pollingHttpClient;
private final boolean ownsPollingClient;
private final AtomicBoolean pollingClientClosed = new AtomicBoolean(false);
private final AtomicLong lastActivityTime = new AtomicLong(0);
private final LocalNodesResponseParser localNodesResponseParser;

Expand Down Expand Up @@ -94,7 +95,9 @@ public void run() {

/** Closes the polling HTTP client if this instance owns it. */
private void closePollingClient() {
if (ownsPollingClient && pollingHttpClient != null) {
if (ownsPollingClient
&& pollingHttpClient != null
&& pollingClientClosed.compareAndSet(false, true)) {
pollingHttpClient.close();
}
}
Expand All @@ -110,6 +113,7 @@ private void closePollingClient() {
public void shutdown() {
shutdownRequested.set(true);
this.interrupt();
closePollingClient();
}

/**
Expand Down