-
Notifications
You must be signed in to change notification settings - Fork 7
Add Alternator vector search support #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't "copy" items, right?
PutItemRequest.builder().tableName("items").item(response.item())will use list of numbers when "item" had a vector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'll add a warning about that in the document.
I got the AI to explain to me (and you?) why we did it this way:
So there were two real options on the read side:
Emit {"L": [...]} (current approach) — transparent; callers use av.l() with no knowledge of FLOAT32VECTOR. Standard SDK code works unmodified. Downside: silent degradation on copy.
Emit {"B": "<base64(magic+floats)>"} (the magic-prefixed encoding) — Float32Vector.isFloat32Vector(av) would return true, callers would call Float32Vector.extractFloats(av). Advantage: round-trip safe, a copy would automatically re-encode as FLOAT32VECTOR on the next write. Downside: all read code needs to be Float32Vector-aware; you can't just use av.l().
The design chose option 1 for read transparency — the goal was that existing DynamoDB code doesn't need to change to read items with vectors. The Float32Vector class was intentionally write-side-only.
Option 2 would have been the safer choice for copy correctness, but at the cost of making reads non-transparent. Neither option is strictly better; it's a deliberate trade-off. The warning in the docs is the acknowledgment of that trade-off.So there were two real options on the read side:
Emit {"L": [...]} (current approach) — transparent; callers use av.l() with no knowledge of FLOAT32VECTOR. Standard SDK code works unmodified. Downside: silent degradation on copy.
Emit {"B": "<base64(magic+floats)>"} (the magic-prefixed encoding) — Float32Vector.isFloat32Vector(av) would return true, callers would call Float32Vector.extractFloats(av). Advantage: round-trip safe, a copy would automatically re-encode as FLOAT32VECTOR on the next write. Downside: all read code needs to be Float32Vector-aware; you can't just use av.l().
The design chose option 1 for read transparency — the goal was that existing DynamoDB code doesn't need to change to read items with vectors. The Float32Vector class was intentionally write-side-only.
Option 2 would have been the safer choice for copy correctness, but at the cost of making reads non-transparent. Neither option is strictly better; it's a deliberate trade-off. The warning in the docs is the acknowledgment of that trade-off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in replacement PR #145: the README includes the copy-item warning and explicit re-encoding example for preserving
FLOAT32VECTORstorage.