Skip to content

Enforce type annotations with Ruff #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkropachev merged 1 commit into from
Jun 27, 2026
Merged

Enforce type annotations with Ruff #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ DOCKER_CACHE_FILE := $(DOCKER_CACHE_DIR)/scylla-image.tar
CERT_CACHE_DIR := $(MAKEFILE_PATH)/.cert-cache
CERT_DIR := $(MAKEFILE_PATH)/tests/scylla

.PHONY: install verify build compile compile-test compile-demo test-unit test-integration test-integration-only test-demo test-demo-only test-all test lint lint-fix clean wait-for-alternator scylla-start scylla-stop scylla-kill scylla-rm docker-pull docker-cache-save docker-cache-load cert-cache-save cert-cache-load help
.PHONY: install verify build compile compile-test compile-demo test-unit test-integration test-integration-only test-demo test-demo-only test-all test lint lint-types lint-fix clean wait-for-alternator scylla-start scylla-stop scylla-kill scylla-rm docker-pull docker-cache-save docker-cache-load cert-cache-save cert-cache-load help

# Default target
help:
Expand All @@ -26,6 +26,7 @@ help:
@echo " test-all - Run unit, integration, and demo tests"
@echo " test - Run all tests"
@echo " lint - Run linters (ruff + mypy)"
@echo " lint-types - Enforce type annotations with ruff"
@echo " lint-fix - Auto-fix linting issues with ruff"
@echo " clean - Remove build artifacts"
@echo " scylla-start - Start 3-node Scylla cluster via Docker"
Expand Down Expand Up @@ -95,7 +96,7 @@ test:
--cov=alternator --cov-report=xml --cov-report=term-missing

# Run linters
lint:
lint: lint-types
uv run ruff check alternator/ tests/ examples/
uv run ruff format --check alternator/ tests/ examples/
$(MAKE) compile-demo
Expand All @@ -106,6 +107,9 @@ lint:
exit 1; \
fi

lint-types:
uv run ruff check --select ANN alternator/ tests/ examples/

# Auto-fix linting issues
lint-fix:
uv run ruff check --fix alternator/ tests/ examples/
Expand Down
Loading