Skip to content

Clean gh-pages branch#30

Merged
haaawk merged 1 commit into
scylladb:gh-pagesfrom
dgarcia360:gh-pages
Sep 21, 2020
Merged

Clean gh-pages branch#30
haaawk merged 1 commit into
scylladb:gh-pagesfrom
dgarcia360:gh-pages

Conversation

@dgarcia360

@dgarcia360 dgarcia360 commented Aug 7, 2020

Copy link
Copy Markdown

@lauranovich @tzach Removes the contents already present in the gh-pages branch.

To enable GitHub pages, please follow https://github.com/dgarcia360/sphinx-scylla-theme#enabling-github-pages

@dgarcia360 dgarcia360 mentioned this pull request Aug 7, 2020
@tzach

tzach commented Aug 8, 2020

Copy link
Copy Markdown

@dgarcia360 can you please explain the PR? is it just about deleting all the HTML files, so they can be generated in the ph-pages branch later?

@dgarcia360

dgarcia360 commented Aug 8, 2020

Copy link
Copy Markdown
Author

@tzach Exactly, it's to make sure the next build does not conflict with the existing files.

We did the same for the python-driver: scylladb/python-driver#51

@tzach tzach self-requested a review August 9, 2020 05:08

@tzach tzach left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haaawk haaawk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is .gitignore removed?

@lauranovich

Copy link
Copy Markdown

@haaawk - it gets readded (but if this is an issue let us know)

@haaawk

haaawk commented Aug 12, 2020

Copy link
Copy Markdown

I guess it's fine if it's only on gh-pages branch.

@dgarcia360

Copy link
Copy Markdown
Author

@haaawk GitHub Actions will update automatically the gh-pages and the script won't create any of the ignored files. Do you prefer me to add the .gitignore file again?

@haaawk

haaawk commented Aug 12, 2020

Copy link
Copy Markdown

No need to add it again @dgarcia360

@lauranovich

Copy link
Copy Markdown

ok so this one is good to merge
@haaawk - please merge this so we can concentrate on #29

@haaawk haaawk merged commit b4f90a5 into scylladb:gh-pages Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants