validator: add Alternator index creation test#452
Merged
Conversation
m-szymon
force-pushed
the
alternator_tests_part1
branch
2 times, most recently
from
May 18, 2026 08:21
517fb7c to
7e14300
Compare
m-szymon
marked this pull request as ready for review
May 18, 2026 08:36
Collaborator
Author
|
As requested I am splitting #392 into smaller commits. |
m-szymon
force-pushed
the
alternator_tests_part1
branch
from
May 18, 2026 08:55
7e14300 to
52fffc0
Compare
ewienik
previously approved these changes
May 18, 2026
Introduce the Alternator integration test suite with shared infrastructure (TableShape, Naming patterns, Injectors for customized AWS SDK calls) and test for basic table and index lifecycle operations: CreateTable, DescribeTable, DeleteTable.
m-szymon
force-pushed
the
alternator_tests_part1
branch
from
May 18, 2026 17:47
52fffc0 to
40fe5ef
Compare
ewienik
approved these changes
May 20, 2026
QuerthDP
approved these changes
May 20, 2026
QuerthDP
left a comment
QuerthDP
left a comment
Member
There was a problem hiding this comment.
Looks good.
Feel free to resolve my comments without any changes if you don't believe they're relevant.
It can be merged as is.
| use tracing::info; | ||
|
|
||
| /// An SDK interceptor that captures the `VectorIndexes` extension field from | ||
| /// the raw `DescribeTable` JSON response as a [`serde_json::Value`]. The |
Collaborator
Author
There was a problem hiding this comment.
Fixed in next PR.
Comment on lines
+103
to
+113
| /// ```ignore | ||
| /// client | ||
| /// .create_table() | ||
| /// // ... | ||
| /// .customize() | ||
| /// .interceptor(JsonBodyInjectInterceptor::new([ | ||
| /// ("VectorIndexes", vector_indexes_json), | ||
| /// ])) | ||
| /// .send() | ||
| /// .await?; | ||
| /// ``` |
Member
There was a problem hiding this comment.
Let's not add ignored code in docstrings. Either make it work or remove
Collaborator
Author
There was a problem hiding this comment.
I think illustrative example is justified here.
Comment on lines
+217
to
+227
| async fn wait_for_index(clients: &[HttpClient], index: &IndexInfo) { | ||
| for client in clients { | ||
| common::wait_for_index(client, index).await; | ||
| } | ||
| } | ||
|
|
||
| async fn wait_for_no_index(clients: &[HttpClient], index: &IndexInfo) { | ||
| for client in clients { | ||
| common::wait_for_no_index(client, index).await; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This could be in common.rs as well
Collaborator
Author
There was a problem hiding this comment.
Could be, but under different name.
Or refactor all tests to wait for all clients they have (unless we want explicitly a subarray). Waiting for single client is potentially flaky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the Alternator integration test suite with shared infrastructure (TableShape, Naming patterns, Injectors for customized AWS SDK calls) and test for basic table and index lifecycle operations: CreateTable, DescribeTable, DeleteTable.