vector-store: stop dropping the CDC driver's supervisor future on shutdown#518
Draft
QuerthDP wants to merge 1 commit into
Draft
vector-store: stop dropping the CDC driver's supervisor future on shutdown#518QuerthDP wants to merge 1 commit into
QuerthDP wants to merge 1 commit into
Conversation
…tdown `spawn_handler_task` raced the driver's supervisor future against a shutdown `Notify` in a `tokio::select!`. The Notify branch almost always won, dropping the supervisor future before it could propagate the new stop timestamp to its internally spawned per-stream fetch tasks. Those tasks are plain `tokio::spawn` + `JoinHandle` with no abort mechanism, so they were orphaned and kept running (and checkpointing) forever. Fixed by pinning the handler future and looping until it resolves on its own once shutdown is requested, rather than dropping it.
QuerthDP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawn_handler_taskraced the driver's supervisor future against a shutdownNotifyin atokio::select!. The Notify branch almost always won, dropping the supervisor future before it could propagate the new stop timestamp to its internally spawned per-stream fetch tasks. Those tasks are plaintokio::spawn+JoinHandlewith no abort mechanism, so they were orphaned and kept running (and checkpointing) forever.Fixed by pinning the handler future and looping until it resolves on its own once shutdown is requested, rather than dropping it.