Sync feature/payment-conf-emails to main#14
Open
nicholas-fierro wants to merge 5 commits intomainfrom
Open
Conversation
…andidate/team processors
Stripe webhook idempotency
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nicholas-fierro
changed the title
sdavisde
requested changes
Nov 30, 2025
| } | ||
| > | ||
| > { | ||
| const paymentIntentId = session.payment_intent as string |
Owner
There was a problem hiding this comment.
Is this assertion necessary? Since this area is important to ensure the system records payments correctly, I want to make sure potential errors are handled gracefully - i've also seen AI hallucinate and add unnecessary type assertions, which might be the case here
| .single() | ||
|
|
||
| if (paymentRecordError) { | ||
| if (paymentRecordError.code === '23505') { |
Owner
There was a problem hiding this comment.
Any idea what this error code means? wondering if we can abstract to a constant for easier understanding
| return ok(true) | ||
| } | ||
|
|
||
| function toDollarAmount(amount: number | null | undefined): number | null { |
Owner
There was a problem hiding this comment.
Might be good to add a block comment to this function explaining what we're expecting the input to be to this function, maybe extracting this to a lib file too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.