fix: reset TargetForConfig condition on no-op reconcile

[steiler]

Problem

When a target briefly drops (e.g. srl3 loses its dsctx) the TargetConfigController calls SetConfigsTargetConditionForTarget(TargetForConfigFailed), setting all Configs for that target to Ready=False.

When the target recovers, the reconciler runs buildIntentInputs. If no intent hash has changed (no new configs, no secret rotation) hasChanged=false and the reconciler returned early:

if !hasChanged {
    log.Info("Transact skip, nothing to update")
    return ctrl.Result{}, nil   // ← never resets the stale Failed condition
}

SetConfigsTargetConditionForTarget(TargetForConfigReady) is only called after a successful transaction, so the stale Failed condition was never cleared. Configs stayed at Ready=False permanently until the next unrelated change triggered a new transaction.

This caused the 22-Srl-Update-Replace suite in CI run #460 to fail: srl3 dropped at 07:14:41, no new intents existed to force a transaction, and the setup Config Check Ready timed out 2 minutes later still seeing ['False'].

Fix

Mirror the main-branch behaviour: call SetConfigsTargetConditionForTarget(TargetForConfigReady) in the no-change early-return path so any stale Failed condition is always cleared when the target is confirmed healthy, even when nothing needs to be transacted.

if !hasChanged {
    log.Info("Transact skip, nothing to update")
    if err := r.cfgMgr.SetConfigsTargetConditionForTarget(
        ctx, targetOrig,
        configv1alpha1.TargetForConfigReady("target ready"),
    ); err != nil {
        return ctrl.Result{},
            errors.Wrap(r.handleError(ctx, targetOrig, "cannot update config status", err), errUpdateStatus)
    }
    return ctrl.Result{}, nil
}

Test plan

• Re-run the sensitive CI suite — 22-Srl-Update-Replace should pass
• Confirm no regression in 11-Sros-Create-Delete, 12-Srl-Create-Delete, 21-Sros-Update-Replace
• Verify that deliberately taking a target not-ready and back-ready (no config change) transitions Configs back to Ready=True

Pairs-with: sdcio/integration-tests#108
Pairs-with: sdcio/data-server#460

[henderiw]

If the status is failed we need to retry iso setting condition to true in my view otherwise we might miss out some configs

[steiler]

what does that mean? do you want to adjust this PR?