fix schema key ordering being lost#454
Merged
Merged
Conversation
Collaborator
|
@alexandernorth there is no test adjustments or additions on the json side is that correct? Are we missing something here? |
Contributor
Author
My understanding is that JSON does not care about the ordering of the keys, unlike XML. So I think we don't need to do additional checks regarding this |
Centralize the alphabetical key order used by key-level tree nodes so json/xml export, path building, filter traversal, and blame all pair key names to values consistently. Co-authored-by: Cursor <cursoragent@cursor.com>
steiler
force-pushed
the
bugfix/fix-key-ordering
branch
from
2e691e6 to
88cc95f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
faebr
approved these changes
Jun 23, 2026
steiler
approved these changes
Jun 23, 2026
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key elements were mis-ordered in generated XML, this corrects that but ensures that key/values match correctly.