Address cmake warnings#119
Merged
Merged
Conversation
lsf37
requested review from
Indanz and
Ivan-Velickovic
and removed request for
Ivan-Velickovic
Member
Author
|
(I'll add a cmake style update commit after review, so the diff isn't completely messed up). |
Indanz
approved these changes
May 29, 2026
|
Tutorial Solution (threads) fails. |
Member
Author
Unrelated, but it does, yes. I'll take a closer look later. It's a bit weird: it works fine for me when I generated the failing task in isolation, but fails when I run it with the test script. |
- bump minimum cmake version to 3.10 - fix package name in FIND_PACKAGE_HANDLE_STANDARD_ARGS. The package being searched for is not cmake-tool, but sel4-tutorials (hence the warning). Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Update all .cmake and CMakeLists.txt files in this repo to the new style settings. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address cmake warnings so the tutorials aren't full of scary warnings on first contact:
bump minimum cmake version to 3.10
fix package name in FIND_PACKAGE_HANDLE_STANDARD_ARGS. The package being searched for is not cmake-tool, but sel4-tutorials (hence the warning).
This unfortunately contains some trailing whitespace stripping that should have been done ages ago, but that is included in my editor. If it's too annoying to review, I can try to remove it, but it should just be 2 or 3 lines.
There is still a warning "Ignoring extra path from command line" that I don't quite understand yet. Have left that untouched for now.