Directive tests added#9
Open
KCXinYuan wants to merge 27 commits into
Open
Conversation
added initial directive boilerplate
got full directive working
added no text and thumbnail directives
added build to gitignore
deleted build file for the repo
| <div class=""> | ||
| <h2>Thumbnail Directive</h2> | ||
| <img src="{{image}}" height="100" width="100" alt="{{title}}"> | ||
| </div> |
There was a problem hiding this comment.
You pass the description property all of the way down to here but then you never actually use it. Just be aware of that.
started adding album logic
added album collections, list and thumbnail working, no full view
got full view to work
added individual album opening, inline pictures
added text to say how to return to album after opening full photo
fixed linting errors
added initial test files
added directive testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got some directives started, but need to hook it all up. Will do it in the morning