Submitting authentication#29
Open
drewferris wants to merge 67 commits into
Open
Conversation
added 30 commits
May 24, 2016 09:27
…orhandling file in lib
added 27 commits
May 27, 2016 10:23
| router.get('/login', basicHTTP, (req, res, next) => { | ||
| User.findOne({username: req.auth.username}, (err, user) => { | ||
| if(err || !user) return next(new Error('Could not login')); | ||
| if (!user.comparePassword(req.auth.password)) return next('Could not sign in'); |
Contributor
There was a problem hiding this comment.
You should return next with new Error here like you did on line 16.
added 2 commits
June 17, 2016 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready to submit