Add a build.rs script to use pkg_config#3
Open
timothee-haudebourg wants to merge 3 commits intoseankerr:masterfrom
Open
Add a build.rs script to use pkg_config#3timothee-haudebourg wants to merge 3 commits intoseankerr:masterfrom
timothee-haudebourg wants to merge 3 commits intoseankerr:masterfrom
Conversation
added 3 commits
June 15, 2019 17:47
Bug fix: the eglGetConfigs function was wrongly typed. `configs' should be a pointer to an array of `EGLConfig', hence have type `*mut EGLConfig' where it had the (wrong) type `EGLConfig'. Refactoring: constants and functions are now ordered by EGL version to have a more sustainable code.
My bad, this commit had nothing to do in this branch.
Author
|
Sorry for the last two commits (reverted), I pushed on the wrong branch. I'll do a separate PR for EGL 1.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default cargo only uses the
-lEGLflag to link against the EGL library and assumeldwill find it. This is not the case on some platforms. I'm using the nix package manager on nixos, and libEGL cannot be found without usingpkg_config.In this PR I've added a new
build.rsscript that will invokepkg_configat compile time. I've tested it on nixos and it does the job.