v1.3.0 - Migration to a dedicated asynchronous API client#6
Open
seanmccabe wants to merge 11 commits into
Open
v1.3.0 - Migration to a dedicated asynchronous API client#6seanmccabe wants to merge 11 commits into
seanmccabe wants to merge 11 commits into
Conversation
seanmccabe
commented
Jan 12, 2026
seanmccabe
commented
Owner
- Created `BggClient` in `api.py` to handle all upstream API interactions.
- Refactored `coordinator.py` to consume the new client.
- Implemented robust XML parsing helpers to fix deprecation warnings.
- Added comprehensive tests for all new code paths, achieving 100% coverage.
- Created a dedicated, fully asynchronous `BggClient` (in `api.py`) to handle all API logic, ensuring strict separation of concerns. - The new `BggClient` handles login sessions securely and asynchronously, eliminating the need for blocking executor jobs. - Updated test suite to provide robust coverage for the new API client structure.
Major refactoring of BGG Sync integration to improve code quality and test coverage. - **BggClient**: Consolidated all API interactions into , introducing robust helper for cleaner XML parsing. - **Coordinator**: Refactored to use and introduced helper to DRY up game data processing logic and standardize subtypes. - **Test Coverage**: Achieved 100% test coverage by adding comprehensive tests for (including edge cases and helper methods) and updating coordinator tests. - **Versioning**: Bumped version to v1.3.0-beta.1 in preparation for release.
seanmccabe
changed the title
…te the component version to 1.2.1.
…todo list, and dedicated sync controls.
seanmccabe
force-pushed
the
feat/seperate-api-concerns
branch
from
22b9529 to
d69d6e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.