Enforce hard sandbox quota ceilings and durable tenant quota accounting#189
Merged
seanwevans merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
pyisolate/errors.py:WallTimeExceeded,OpenFilesExceeded,NetworkExceeded,OutputExceeded,ChildWorkExceeded, andTenantQuotaExceeded, and exported them from the package API viapyisolate/__init__.py.SandboxThread(pyisolate/runtime/thread.py): wall-clock preemption via a tracing guard (sys.settrace), open-file accounting withweakref.finalizeon opened file objects, network-op counting in guarded socket connects, output-byte accounting in a_postwrapper, and concurrent child-work limits by wrappingthreading.Thread.start; recorded the terminal cause intermination_reason.Supervisor/Sandbox(pyisolate/supervisor.py) to accept and pass through the new per-sandbox quota knobs, exposedSandbox.termination_reason, and implemented durable tenant accounting using an append-only ledger file configured by thePYISOLATE_QUOTA_LEDGERenvironment variable that is replayed at startup and updated on spawn (raisingTenantQuotaExceededwhen exhausted).tests/test_thread_quota.pyandtests/test_supervisor.py.Testing
PYTHONPATH=. pytest -q tests/test_thread_quota.py tests/test_supervisor.pyand verified the test suite completed successfully.PYTHONPATH=. pytest -q tests/test_supervisor.py -vvandPYTHONPATH=. pytest -q tests/test_thread_quota.py -vv, both of which passed; final run reported30 passed.Codex Task