Rollback tenant quota reservation on spawn failures#192
Merged
seanwevans merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_tenant_usageand durable quota ledger remain consistent across failure paths.Description
usage_reservedflag and preserved the earlyself._record_tenant_usage(tenant, 1)reservation while wrapping sandbox creation/startup and registry update in a guardedtry/exceptblock inSupervisor.spawn()(filepyisolate/supervisor.py).-1delta via_record_tenant_usage(tenant, -1)to restore quota accounting.Sandboxhandle on success.tests/test_supervisor.pyto simulate failures and assert both in-memory and on-disk ledger consistency.Testing
test_spawn_start_failure_rolls_back_tenant_usage_and_ledgerwhich monkeypatchesSandboxThread.startto raise and verifies_tenant_usageand ledger contain the compensating-1entry.test_spawn_registry_failure_rolls_back_tenant_usage_and_ledgerwhich monkeypatchesrecovery.update_sandboxto raise and verifies registry cleanup,_tenant_usage, and ledger replay behavior.pytest -q tests/test_supervisor.pyand all tests passed (24 passed).Codex Task