Localize sandbox thread quota enforcement to sandbox imports#195
Merged
seanwevans merged 1 commit intomainfrom Apr 21, 2026
Merged
Localize sandbox thread quota enforcement to sandbox imports#195seanwevans merged 1 commit intomainfrom
seanwevans merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
threading.Thread.startwhich could affect non-sandbox host threads.Description
threading.Thread.startpatch with a sandbox-scopedThreadsubclass factory via_make_sandbox_thread_classthat implements quota checks and accounting.threadingmodule from_wrap_module(...)when sandboxed code importsthreading, withThreadset to the sandbox-scoped class so only sandbox imports are affected.test_sandbox_threading_patch_is_local_and_does_not_touch_global_startintests/test_thread_extra.pyto verify host threads run concurrently and thatthreading.Thread.startidentity never changes globally.Testing
pytest -q tests/test_thread_extra.py tests/test_thread_quota.py, all tests passed:13 passed.threading.Thread.start.Codex Task