Skip to content

Conversation

@bverbeken
Copy link
Member

This PR re-adds the logic (added in https://github.com/seatsio/seatsio-python/pull/127/changes and reverted in #131) to bump the version number in uv.lock

This PR also adds:

  • building of a wheel (sdist = source recipe, rebuilt on every machine; wheel = frozen, known-good installable artifact)
  • a setuptools config in pyproject.toml that indicates which sources to include, namely everything under /seatsio. This is what was missing and what caused the resulting artifact to not contain the required files.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the version bumping process in the release script by re-introducing logic to update the uv.lock file and adds proper setuptools configuration for package building. The changes improve the release process by using the uv version command to handle version updates and ensuring proper package inclusion when building wheels.

  • Refactored version bumping to use uv version command which updates both pyproject.toml and uv.lock
  • Added validation to ensure pyproject.toml version matches the latest release tag before bumping
  • Added setuptools configuration to properly include the seatsio package and its subpackages in built artifacts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
release.mjs Refactored version bumping logic to use uv version command for updating both pyproject.toml and uv.lock, and added validation to ensure version consistency before bumping
pyproject.toml Added setuptools package configuration to explicitly include the seatsio package and its subpackages in the built wheel distribution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bverbeken bverbeken merged commit 0e11a9d into master Jan 7, 2026
2 checks passed
@bverbeken bverbeken deleted the fix-version-bumping-when-releasing-revisited branch January 7, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants