Add comprehensive test suite and fix critical bugs#3
Open
lixen-wg2 wants to merge 2 commits intosebastiw:mainfrom
Open
Add comprehensive test suite and fix critical bugs#3lixen-wg2 wants to merge 2 commits intosebastiw:mainfrom
lixen-wg2 wants to merge 2 commits intosebastiw:mainfrom
Conversation
- Add 7 new EUnit test cases covering all requested scenarios: * client connect (unsuccessful) to non-existing server * client connect (successfully) to existing server * second client connect (successfully) to same server * client send data message to server * server send data message to client * server exits * clients retry - Fix critical bugs in codebase: * sock_path.erl:27 - Fix incorrect gen_server:start_link call * sock_assoc.erl:55 - Fix inconsistent map key usage (path vs paths) * sock_assoc.erl:64 - Fix map key access in get_paths function - Improve test infrastructure: * Replace timer:sleep with recursive checking for reliability * Add helper functions for condition waiting * Fix old broken connect_accept_1_test * Add proper setup/teardown for application lifecycle - All 28 tests now pass with comprehensive coverage of connection management
- Add PropEr dependency and eunit_formatters to test profile in rebar.config - Create sock_proper_tests.erl with 8 comprehensive properties testing: * Endpoint creation with valid/invalid ports * Association creation and lifecycle management * Port collision detection * Concurrent connection handling * Endpoint options and configuration - Integrate PropEr tests into existing EUnit test suite - Add detailed README_PROPER.md documenting all test properties and usage - Tests cover edge cases and provide extensive input space coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 7 new EUnit test cases covering all requested scenarios:
Fix critical bugs in codebase:
Improve test infrastructure:
Create sock_proper_tests.erl with 8 comprehensive properties testing:
Integrate PropEr tests into existing EUnit test suite
Add detailed README_PROPER.md documenting all test properties and usage
Tests cover edge cases and provide extensive input space coverage