fix(deps): update react-day-picker to v10 and reinstall calendar component#109
Merged
Conversation
…onent - Bump react-day-picker from ^9.14.0 to ^10.0.1 in web and example apps - Reinstall the shadcn calendar component from the registry to pull upstream fixes (rename removed `table` classNames slot to `month_grid`, add locale support, fix a `relative` typo, and update Tailwind data-slot syntax); the registry also refreshed the button component dependency - Add NODE_USE_SYSTEM_CA / NODE_USE_ENV_PROXY / NODE_EXTRA_CA_CERTS to turbo globalPassThroughEnv so build workers can trust a proxy CA and honor an env-configured proxy Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BgyqcL7ZTyzR6DzKA1oiDE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s calendar UI to be compatible with react-day-picker v10, aligns the shared shadcn calendar component implementation across apps/web and examples/respondeo, and adjusts Turbo env filtering so Next.js build workers can honor proxy/CA settings.
Changes:
- Bump
react-day-pickerto^10.0.1in bothapps/webandexamples/respondeo(and lockfile). - Reinstall/refresh shadcn
calendar(and itsbuttondependency) to matchreact-day-pickerv10classNamesAPI and add locale support. - Add
NODE_USE_SYSTEM_CA,NODE_USE_ENV_PROXY,NODE_EXTRA_CA_CERTStoturbo.jsonglobalPassThroughEnvfor build-worker networking compatibility.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| turbo.json | Pass through Node proxy/CA env vars to Turbo tasks/build workers. |
| pnpm-lock.yaml | Lockfile updates for react-day-picker@10.0.1 and dependency graph adjustments. |
| apps/web/package.json | Bump react-day-picker dependency to v10. |
| examples/respondeo/package.json | Bump react-day-picker dependency to v10. |
| apps/web/components/ui/calendar.tsx | Update calendar wrapper to v10 slots (month_grid) and add locale forwarding + data-day formatting changes. |
| examples/respondeo/components/ui/calendar.tsx | Same calendar updates as apps/web for example parity. |
| apps/web/components/ui/button.tsx | Refresh shadcn button styles/variants that calendar depends on. |
| examples/respondeo/components/ui/button.tsx | Same button refresh for example parity. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (2)
apps/web/components/ui/calendar.tsx:159
CalendarDayButtoncreates arefand runs an effect to focus it whenmodifiers.focusedis true, but therefis never attached to the rendered element. SinceButtonis notforwardRef-based (seeapps/web/components/ui/button.tsx), this focus logic is currently a no-op and likely breaks keyboard focus management for the customDayButton.
const ref = React.useRef<HTMLButtonElement>(null);
React.useEffect(() => {
if (modifiers.focused) ref.current?.focus();
}, [modifiers.focused]);
examples/respondeo/components/ui/calendar.tsx:159
CalendarDayButtoncreates arefand runs an effect to focus it whenmodifiers.focusedis true, but therefis never attached to the rendered element. SinceButtonis notforwardRef-based (seeexamples/respondeo/components/ui/button.tsx), this focus logic is currently a no-op and likely breaks keyboard focus management for the customDayButton.
const ref = React.useRef<HTMLButtonElement>(null);
React.useEffect(() => {
if (modifiers.focused) ref.current?.focus();
}, [modifiers.focused]);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #88 (Renovate's plain dependency bump), which will be closed automatically on the next Renovate run.
What changed
react-day-pickerfrom^9.14.0→^10.0.1inapps/webandexamples/respondeo.calendarcomponent from the registry (shadcn add calendar --overwrite, then formatted withoxfmt— no hand-edits). This pulls the upstream fixes needed for v10:tableclassNames slot →month_grid(thetableslot no longer exists in v10'sClassNamestype).localesupport (forwarded toDayPicker,formatMonthDropdown, anddata-day).elative→relativetypo inrange_start.[[data-slot=…]_&]→in-data-[slot=…]) and class ordering.button.tsxdependency, which came along as-is.NODE_USE_SYSTEM_CA/NODE_USE_ENV_PROXY/NODE_EXTRA_CA_CERTStoglobalPassThroughEnvinturbo.jsonso build workers can trust a proxy CA from the system store and honor an env-configured proxy. Turbo's strict env mode otherwise filters these out before they reach the Next.js build workers, which brokenext/ogfont fetches at build time.Verification
pnpm tsc— passes across all workspace packages and the standalone example.pnpm build— full turbo build is green (static generation of OG images included).pnpm format:check— clean.apps/webandexamples/respondeocalendar/button components are byte-identical and pin the samereact-day-pickerversion.🤖 Generated with Claude Code
Generated by Claude Code