Add.messages by sebferrer · Pull Request #15 · sebferrer/jays

sebferrer · 2018-11-02T01:45:13Z

No description provided.

bastienguillon · 2018-11-03T15:06:03Z

+			"Twilight is shining through the barrier. It seems your journey is finally over. You're filled with DETERMINATION.",
+			"Welcome to The Blunder of JayS",
+			"This is the first test message",
+			"We're awesomes!"));


Je te hais.

sebferrer · 2019-02-10T18:18:21Z

 					message: "Um, yes.",
-					animation: <IDialogAnimation>{ type: DialogAnimation.None },
-					animation_factor: 0,
+					animation: { type: DialogAnimation.None },


Pourquoi virer le <DialogAnimation alors que tu le laisses sur les autres ?

…e, and are now responsive

bastienguillon · 2021-05-01T12:21:44Z

+/*
+export function get_actionable_entities(canvas_w?: number, canvas_h?: number): ActionableEntity[] {
+	return [
+		new Sign("angry_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, angry_dialog),
+		new Sign("sample_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, sample_dialog),
+		new Sign("glitchy_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, glitchy_dialog)
+	]
+}*/


Suggested change

/*

export function get_actionable_entities(canvas_w?: number, canvas_h?: number): ActionableEntity[] {

return [

new Sign("angry_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, angry_dialog),

new Sign("sample_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, sample_dialog),

new Sign("glitchy_dialog", new Sprite(0, 0, 29, 31), new Point(canvas_w / 2 - 15, canvas_h / 2 - 100), 29, 31, true, 0, 1, null, 0.5, glitchy_dialog)

]

}*/

bastienguillon · 2021-05-01T12:24:41Z

+export function get_actionable_entities(canvas_w?: number, canvas_h?: number): ActionableEntity[] {
+	return [
+		new Sign("angry_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, angry_dialog),
+		new Sign("sample_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, sample_dialog),
+		new Sign("glitchy_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, glitchy_dialog)
+	]
+}


Les paramètres ne sont pas utilisés : pas la peine d'avoir une fonction pour ça

Suggested change

export function get_actionable_entities(canvas_w?: number, canvas_h?: number): ActionableEntity[] {

return [

new Sign("angry_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, angry_dialog),

new Sign("sample_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, sample_dialog),

new Sign("glitchy_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, glitchy_dialog)

]

}

export const actionable_entities = [

new Sign("angry_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, angry_dialog),

new Sign("sample_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, sample_dialog),

new Sign("glitchy_dialog", new Sprite(0, 0, 29, 31), null, 29, 31, true, 0, 1, null, 0.5, glitchy_dialog)

];

Je les utilisais à un moment, d'où la fonction, je réfléchis encore à savoir si on va en avoir besoin ou pas. Pour centrer certains elements sur la carte par exemple.

bastienguillon · 2021-05-01T12:34:01Z

+import { IActionable } from "./iactionable";
+import { IMAGE_BANK } from "./main";
+
+export abstract class ActionableEntity extends Entity implements IDrawable, IActionable {


Un détail mais en TS j'aime bien préfixer les classes abstraites par un A, je trouve qu'on s'y retrouve mieux, même logique que les noms d'interfaces

AActionableEntity

bastienguillon · 2021-05-01T12:36:02Z

+        this.action_hitbox_ratio = action_hitbox_ratio == null ? 0 : action_hitbox_ratio;
+        this.actionable = false;
+        this.occuring = false;
+        if (position != null) {


Le fait que la position et donc la hitbox soient optionnelles me laisse penser qu'il devrait y avoir un niveau d'abstraction supplémentaire

abstract class AActionableEntity --> entités actionnable
abstract class AHitBoxActionableEntity extends AActionableEntity --> entités actionnable avec hitbox

Fort probable effectivement

D'un autre côté je me demande si une entité sans position a vraiment du sens

C'est pour la set de manière différée, il y a un algo qui place certaines collections d'entités de manière aléatoire mais qui a besoin d'attendre que la room soit totalement générée pour prendre compte des espaces indisponibles

bastienguillon · 2021-05-01T12:36:54Z

+
+    public set_position(position: Point) {
+        this.position = new Point(position.x, position.y);
+        this.action_hitbox = new ActionableEntityHitbox(this.id + "-hitbox", null,


Suggested change

this.action_hitbox = new ActionableEntityHitbox(this.id + "-hitbox", null,

this.action_hitbox = new ActionableEntityHitbox(`${this.id}-hitbox`, null,

sebferrer added 3 commits November 2, 2018 02:41

MessageBoxes instanciable + text size adaptation

c983162

Oops, remove useless file

f2f8746

MessageBox scrolling

066abe1

bastienguillon reviewed Nov 3, 2018

View reviewed changes

bastienguillon added 2 commits February 5, 2019 00:34

cleanup

56cb80b

draw characters one by one

cbe5f71

bastienguillon force-pushed the add.messages branch from efeff71 to 874c5c5 Compare February 5, 2019 21:50

add shaky messages animation

c304440

bastienguillon force-pushed the add.messages branch from 874c5c5 to c304440 Compare February 5, 2019 21:51

bastienguillon and others added 7 commits February 6, 2019 02:15

handle choices and select them + handle closing dialog

b1a548b

small fix

31ee4c3

tweaking

0baf67a

Animation factor directly included in IDialogAnimation

19f3c2b

TOEIC: 780

010288d

Blur audio button on click

55b050a

fix dialog answers animation

79a8692

bastienguillon force-pushed the add.messages branch from 7ea4657 to 79a8692 Compare February 8, 2019 16:40

sebferrer commented Feb 10, 2019

View reviewed changes

sebferrer added 12 commits February 10, 2019 21:07

Add pause system

12d6a06

Messages are no more requiring _line_width_in_characters and Monospac…

313a832

…e, and are now responsive

Add 3 glitchy effects (spinny, splitted, uppercase)

8e815a6

upgrade gulp 3 --> 4

d0f5d61

entities height perspective + WIP actionable objects

69d77c3

[WIP] actionable objects

47a8663

actionable entities linked to floor + room

38aa953

spread entities

ee76000

entities - floor/room link

bfdf7d8

actionable entities in a separate file

8b46094

drawable entities + [WIP] rocks

3af06d0

[WIP] spread entities + random locations

b3944e0

spread entities + random locations --> some improvements

14e9a3f

bastienguillon reviewed May 1, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add.messages#15

Add.messages#15
sebferrer wants to merge 26 commits into
masterfrom
add.messages

sebferrer commented Nov 2, 2018

Uh oh!

bastienguillon Nov 3, 2018

Uh oh!

sebferrer Nov 5, 2018

Uh oh!

sebferrer Feb 10, 2019 •

edited

Loading

Uh oh!

bastienguillon May 1, 2021

Uh oh!

bastienguillon May 1, 2021

Uh oh!

sebferrer May 1, 2021

Uh oh!

bastienguillon May 1, 2021

Uh oh!

bastienguillon May 1, 2021

Uh oh!

sebferrer May 1, 2021

Uh oh!

bastienguillon May 1, 2021

Uh oh!

sebferrer May 1, 2021

Uh oh!

bastienguillon May 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	this.action_hitbox = new ActionableEntityHitbox(this.id + "-hitbox", null,
	this.action_hitbox = new ActionableEntityHitbox(`${this.id}-hitbox`, null,

Conversation

sebferrer commented Nov 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebferrer Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sebferrer Feb 10, 2019 •

edited

Loading