Open
Conversation
- make the generated HTML tree simpler, using more concise hierarchical patterns the div, ul, li and span tags - use nested CSS style to manage spacing and additional style configurations - add TS support to improve type safety and DX - update package.json with TS package and jest to update tests Signed-off-by: SantiR <santiriosolaya@gmail.com>
- remove old method and old tests - remove unncesary files form /examples folder Signed-off-by: SantiR <santiriosolaya@gmail.com>
- add multiple test cases - use jest to separate all the tests cases in logical groups for better clarity and coverage Signed-off-by: SantiR <santiriosolaya@gmail.com>
- regenerate HTML outputs for each case Signed-off-by: SantiR <santiriosolaya@gmail.com>
Sr-santi
changed the title
Signed-off-by: SantiR <santiriosolaya@gmail.com>
DaveSauce
approved these changes
Apr 7, 2025
DaveSauce
left a comment
DaveSauce
left a comment
There was a problem hiding this comment.
This looks good to me. This was copied from a patch that we're doing in Cortex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: update README
Signed-off-by: SantiR santiriosolaya@gmail.com