feat: add PNG format support and switch to vibetty-screenshot crate#6
Merged
Conversation
- Rename render_screen_to_jpeg to render_screen_to_image - Add format parameter to support both JPEG and PNG output - Add Copy trait to ImageFormat enum - Use PNG as default format for scroll operations - PNG preserves transparency (RGBA), JPEG uses RGB only Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove the bundled src/screenshot/ module and depend on the standalone vibetty-screenshot library (v0.1.0) from GitHub instead. The API is unchanged — all existing callers in ws.rs work without modification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add configurable image format (png/jpeg) via CLI flag, defaulting to jpeg. Propagates through AppState to all rendering call sites: HTTP screenshot endpoint, WebSocket screen sync, and scroll operations. Route changed from /screenshot.jpeg to /screenshot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add image crate back to Cargo.toml (still used by ws.rs for resize/crop/encode) - Remove src/bin/font_render_test.rs (references deleted screenshot module) - Fix state move-after-use by extracting image_format before AppState construction Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Disable default features and enable only the ab_glyph feature for vibetty-screenshot, switching the font rendering backend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update vibetty-screenshot dependency from v0.1.0 to v0.2.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
-f/--image-formatto specify output format🤖 Generated with Claude Code