Conversation
| module.exports = { | ||
| extends: 'recommended', | ||
| rules: { | ||
| 'no-invalid-interactive': false, |
There was a problem hiding this comment.
I wonder if it's a mistake to turn this one off.
There was a problem hiding this comment.
For accessibility, absolutely. For backward compatibility, however, no. We will have to fix accessibility when we are ready to break compatibility. Moving actions to dom nodes that are interactive will definitely break things.
.travis.yml
Outdated
| @@ -1,10 +1,11 @@ | |||
| --- | |||
There was a problem hiding this comment.
Do we still need this file if we're switching to GitHub Actions?
There was a problem hiding this comment.
It's not going to run given travisci.org is dead. 👍
There was a problem hiding this comment.
For some reason github is still expecting a travis run. This may be fixable through settings.
There was a problem hiding this comment.
Ah, good call. I just deleted it from the required status checks.
| @@ -1,5 +1,20 @@ | |||
| # MDC-Ember Changelog | |||
|
|
|||
| ### 0.1.0 Kerry Blue Terrier (November 22, 2021) | |||
There was a problem hiding this comment.
The naming structure is {{gem / semiprecious stone}} {{dog breed}}, where both tokens begin with the same letter, so this name would need a K-based gem/stone before it. Might I suggest Kunzite?
There was a problem hiding this comment.
That name fits the formatting.
| Thank you to all of our wonderful contributors! Want to be on this list? [Check out our contributing guide!](https://github.com/secondstreet/ember-material-components-web/blob/master/CONTRIBUTING.md) ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)): | ||
|
|
||
|
|
||
| <!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section --> |
There was a problem hiding this comment.
Don't forget to add yourself as a contributor via the CLI.
| * @param {Boolean} checked | ||
| */ | ||
| onchange: x => x, | ||
| onchange: (x) => x, |
There was a problem hiding this comment.
It looks like prettier settings may have changed (please revert them) or it may not have run for this file/PR (please run it).
There was a problem hiding this comment.
I allowed them to change from the old defaults to the new defaults. Please confirm you want non-default settings.
There was a problem hiding this comment.
If they are supported as options, yes. I'd favor that over changing big chunks of the codebase as part of this dependency update PR.
There was a problem hiding this comment.
There is an option for this, but my personal preference is to always use prettier defaults rather than bikeshed. Big chunks of this codebase are being changed anyway.
addon/components/mdc-checkbox.js
Outdated
| }); | ||
| }, | ||
|
|
||
| _sync() { |
There was a problem hiding this comment.
This name is easy to confuse with sync(), which the class gets from this mixin. Perhaps _syncCheckboxState?
| isTwo: equal('size', 2), | ||
| isThree: equal('size', 3), | ||
| height: computed('size', function() { | ||
| height: computed('size', function () { |
There was a problem hiding this comment.
See other comment re: prettier
There was a problem hiding this comment.
There is no option for this one.
|
Superceded by #146 |
2 participants
No description provided.