feat: ✨ add build process chapter#7
Open
lwjohnst86 wants to merge 13 commits into
Open
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
signekb
requested changes
Jul 14, 2026
signekb
left a comment
signekb
left a comment
Member
There was a problem hiding this comment.
Very nice 👌 Some suggestions:
Comment on lines
+139
to
+140
| For data packages using `datapackage.json` as the metadata format, Sprout will | ||
| also (re-)generate the file from the Python code. See @sec-metadata and |
Member
There was a problem hiding this comment.
Is a data package doesn't use datapackage.json, will/should Sprout just not check the data against the metadata?
Member
Author
There was a problem hiding this comment.
Sprout will also check the data against the metadata. That's because we have the Properties that people manually fill in rather than manually edit the JSON file.
github-project-automation
Bot
moved this from In Review
to In Progress
in Product development
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I took the build process I wrote in feasibility-data and refined it into a standalone chapter here.
Needs a thorough review.
Checklist
just run-all