feat: ✨ add struct for the metadata of the data package#59
Open
lwjohnst86 wants to merge 15 commits into
Open
Conversation
signekb
requested changes
Jul 6, 2026
signekb
left a comment
signekb
left a comment
Member
There was a problem hiding this comment.
Very nice work - nice to see things getting more concrete 👍
Some suggestions:
github-project-automation
Bot
moved this from In Review
to In Progress
in Product development
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
signekb
requested changes
Jul 6, 2026
signekb
left a comment
signekb
left a comment
Member
There was a problem hiding this comment.
Oh, just noticed two minor things:
github-project-automation
Bot
moved this from In Review
to In Progress
in Product development
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
signekb
previously approved these changes
Jul 6, 2026
github-project-automation
Bot
moved this from In Review
to Approved
in Product development
martonvago
reviewed
Jul 6, 2026
martonvago
left a comment
martonvago
left a comment
Contributor
There was a problem hiding this comment.
Very nice! Just some questions ⭐
…ropagate into feat/structs-for-metadata
martonvago
requested changes
Jul 7, 2026
github-project-automation
Bot
moved this from In Review
to In Progress
in Product development
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
…ropagate into feat/structs-for-metadata
github-project-automation
Bot
moved this from In Review
to Approved
in Product development
signekb
requested changes
Jul 9, 2026
signekb
left a comment
signekb
left a comment
Member
There was a problem hiding this comment.
Very minor comment related suggestions ✏️
github-project-automation
Bot
moved this from Approved
to In Progress
in Product development
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
martonvago
approved these changes
Jul 14, 2026
github-project-automation
Bot
moved this from In Review
to Approved
in Product development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the metadata that we need from the
datapackage.jsonfile (or similar).Needs a thorough review.
Checklist
just run-all