Skip to content

Fix facebook provider remount bug#218

Open
WayneEllery wants to merge 2 commits intoseeden:mainfrom
WayneEllery:fix-facebook-provider-remount-bug
Open

Fix facebook provider remount bug#218
WayneEllery wants to merge 2 commits intoseeden:mainfrom
WayneEllery:fix-facebook-provider-remount-bug

Conversation

@WayneEllery
Copy link

Fixed bug with FacebookProvider where if provider was unmounted and then remounted isReady would not be set to true so api would never be set

  • Also added in package-lock.json to git to ensure same version of packages are always installed

lock file should be in git to ensure same versions of packages are
always installed
This bug resulted in 'Facebook API is not initialized' error
@iplatonenko
Copy link

@seeden Hi!
Could you please merge this fix? cause it's not really possible to use actual version without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants