Skip to content

Asset editor improvements#224

Open
fredsa wants to merge 22 commits intosehugg:masterfrom
fredsa:asseteditor
Open

Asset editor improvements#224
fredsa wants to merge 22 commits intosehugg:masterfrom
fredsa:asseteditor

Conversation

@fredsa
Copy link
Contributor

@fredsa fredsa commented Mar 1, 2026 •
edited
Loading

  • Reformat affected files prior to other commits
  • Fix asset undo (Asset Editor doesn't undo properly #213)
  • Implement asset editor redo
  • Create distinct undo for each asset edit
  • Limit asset editor to undos in current session
  • Fix stacking "no more undo/redo" alerts
  • Ignore ';;' that is a new ';;{…};;' asset block
  • Asset editor displays line number ranges and header
  • Click line number range to jump to highlighted lines
  • Show errors for assets with incorrect number of values
  • Fix bad edits when source has different length values
  • Fix length new data values written
  • Align thumbnails to the top to prevent visual jumps
  • Dismiss highlighted lines on user interaction
  • Replace affected asset range, not entire file contents
  • Asset undo inside source editor shows affected lines
  • Likely fixes [Possible bug] Asset editor gets reset #62

@fredsa fredsa changed the title Asset editor fix undo #213, add redo Asset editor improvements Mar 2, 2026
@fredsa
Copy link
Contributor Author

fredsa commented Mar 2, 2026

Updated PR title and the initial comment

@fredsa fredsa mentioned this pull request Mar 2, 2026
Open
fredsa added 21 commits March 2, 2026 15:12
@fredsa
reformat src/ide/pixeleditor.ts
bf192f4
@fredsa
reformat src/ide/views/asseteditor.ts
abf9ebd
@fredsa
reformat src/ide/windows.ts
955d872
@fredsa
fix asset undo sehugg#213
b5d3515
@fredsa
distinct undo for each asset editor edit
d107610
@fredsa
limit asset editor undo to current session
fdd6af4
@fredsa
asset editor redo
14401f5
@fredsa
prevent stacking alerts: no more undo/redo
d37b305
@fredsa
Add missing ;; asset closing blocks
9468a32
@fredsa
display asset line numbers, headers, and errors
3a997d4 
- For each detected asset, display its line number
  and header snippet for reference.
- When asset data cannot be found or the number
  of values detected is incorrect, and inline
  error message is displayed instead of a (broken)
  asset editor.
@fredsa
fix asset editor replace with different length text
8ca6cdd
@fredsa
stable asset thumbnail position
323c83e 
align-items: flex-start
@fredsa
asset editor pads rewritten bytes
2c77a42 
Use bpw or verilog spec to pad correct number of chars.
@fredsa
end of asset ;; must not be ;;{
e7ef6ea 
Do not treat a new asset block
as the end of a previous block
@fredsa
assets show start/end line numbers
bd83d74
@fredsa
rename line to startline
782a3c1
@fredsa
clicking asset line range highlights source lines
3ff7838
@fredsa
dismiss highlighted lines on user interaction
d1e2118
@fredsa
highlight invalid asset's header line only
d84e943
@fredsa
Improve asset editor source undo
75b80f6 
Asset editor replaces text ranges instead of
the entire source file. Undo inside the source
code now scrolls asset editor edits into view,
and selects the text being edited, so that what
is being (un)edited is much clearer. Also, undo
history is no longer burdened by full file edits.
@fredsa
Add affordance for asset line numbers
aef263e
@fredsa
Copy link
Contributor Author

fredsa commented Mar 2, 2026

Rebased commits on origin/master

@fredsa
Copy link
Contributor Author

fredsa commented Mar 2, 2026

Last two commits add:

  • affordance for asset line numbers in asset editor
  • clickable asset editor decorations in source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Possible bug] Asset editor gets reset

1 participant

@fredsa