Pipeline giga static block processing#3495
Conversation
PR SummaryHigh Risk Overview Async pipeline: Execution paths: Giga synchronous and OCC flows take precomputed static metadata (by index or checksum), short-circuit on static failures, and call Tests & minor fix: New Reviewed by Cursor Bugbot for commit 391db04. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
- Coverage 59.10% 59.09% -0.02%
==========================================
Files 2187 2187
Lines 182238 182431 +193
==========================================
+ Hits 107712 107801 +89
- Misses 64868 64961 +93
- Partials 9658 9669 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5d8b337. Configure here.
5d8b337 to
87a27a2
Compare
| func (app *App) pruneGigaStaticPipelineLocked(height int64) { | ||
| for key := range app.gigaStaticPipeline { | ||
| if key.height+gigaStaticPipelineRetentionBlocks < height { | ||
| delete(app.gigaStaticPipeline, key) |
There was a problem hiding this comment.
This can still grow unbounded for the same height. Since the churn here is driven by proposers, we should cap this to some maximum. Otherwise OOM is a concern.

Summary
Tests
go test ./appmake giga-integration-testmake giga-mixed-integration-testmake autobahn-integration-testmake parquet-integration-test