Remove crisis module code and store#3510
Conversation
Drop x/crisis from the Sei app module manager, init-genesis order, end blocker, invariant registration, init flags, and app-owned keeper state. Crisis has no dedicated mounted KV store in app/app.go, so the rootmulti store key list is unchanged. Also decouple crisis package tests from the full app now that App no longer exposes CrisisKeeper. Tested with: go test ./app ./app/legacyabci ./cmd/seid/cmd ./sei-cosmos/x/crisis/... Upgrade tested with a 4-node Docker cluster: started from the pre-removal binary, passed software upgrade v99.0.1-crisis-removal at height 342, restarted all validators on the removal binary, and verified all nodes reached height 514 with catching_up=false and matching app hash A53F9F78B05C8F6C07247186EF5BFB89D5BCFE7535AE52E54895B57E1844485E.
PR SummaryHigh Risk Overview On-chain cleanup is scheduled for upgrade Harness and ops updates drop crisis from local genesis overrides, state dump / seidb module lists, and wasmd / IBC simapp wiring so tests and tooling match the main app. Reviewed by Cursor Bugbot for commit 4972f18. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 59.30% 59.25% -0.06%
==========================================
Files 2127 2129 +2
Lines 175876 176696 +820
==========================================
+ Hits 104305 104700 +395
- Misses 62473 62868 +395
- Partials 9098 9128 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codchen
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f76f011. Configure here.
| @@ -170,8 +169,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) { | |||
| rootCmd.AddCommand(server.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Marshaler)) | |||
| } | |||
|
|
|||
| func addModuleInitFlags(startCmd *cobra.Command) { | |||
| crisis.AddModuleInitFlags(startCmd) | |||
There was a problem hiding this comment.
This would break the startup for anyone setting the flag.
Perhaps a more graceful approach is to print a WARNING saying this is noop, and flag will be removed in the next release.
Alternatively a more meaningful fatal error to point them to some TBD comms (e.g. release notes) that would explain the module removal).
| app.SetStoreLoader(upgradetypes.UpgradeStoreLoader(upgradeInfo.Height, &storeUpgrades)) | ||
| } | ||
|
|
||
| if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) { |
There was a problem hiding this comment.
Going forward since v6.5, upgrade names will follow v<major>.<minor> format. No more repetitive .0 suffix.
| if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) { | |
| if (upgradeInfo.Name == "v6.6") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) { |
| } | ||
| } | ||
| app.UpgradeKeeper.SetModuleVersionMap(ctx, app.mm.GetVersionMap()) | ||
| return app.mm.InitGenesis(ctx, app.appCodec, genesisState, app.genesisImportConfig) |
There was a problem hiding this comment.
Genesis JSON import skips over unknown module names. but streaming genesis would i think panic because it seem to directly index modules by name and proceed to initialise.
If I haven't missed anything, we would then need to skip over removed modules here.
2 participants
Summary
Test Plan